JIT: Insert writebacks more eagerly #87869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before starting replacements within a statement we now look for physically promoted struct locals passed as call args and write those back if necessary. This has two benefits: 1. It avoids creating a lot of comma nodes that we would otherwise create 2. More importantly, it allows morph's last-use copy omission to kick in because we no longer have complex trees as the argument. Fix dotnet#87471
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBefore starting replacements within a statement we now look for physically promoted struct locals passed as call args and write those back if necessary. This has two benefits:
Fix #87471
|
5 tasks
Member
Author
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo |
40 tasks
EgorBo
approved these changes
Jun 23, 2023
Member
EgorBo
left a comment
EgorBo
left a comment
There was a problem hiding this comment.
lgtm assuming the arm failure is unrelated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before starting replacements within a statement we now look for physically promoted struct locals passed as call args and write those back if necessary. This has two benefits:
Fix #87471