Skip to content

Convert Volatile to JIT intrinsics #88073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 29, 2023
Merged

Convert Volatile to JIT intrinsics #88073

merged 12 commits into from
Jun 29, 2023

Conversation

@MichalPetryka
Copy link
Contributor

Removes big VM implementations and improves codegen.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jun 26, 2023
@ghost
Copy link

ghost commented Jun 26, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Removes big VM implementations and improves codegen.

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

This was referenced Jun 27, 2023
Closed
Closed
Closed
EgorBo
EgorBo reviewed Jun 27, 2023
View reviewed changes
EgorBo
EgorBo reviewed Jun 27, 2023
View reviewed changes
EgorBo
EgorBo reviewed Jun 27, 2023
View reviewed changes
EgorBo
EgorBo reviewed Jun 27, 2023
View reviewed changes
EgorBo
EgorBo approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice diffs, the jit side LGTM, @jkotas can you please check the vm side?

jkotas
jkotas reviewed Jun 27, 2023
View reviewed changes
jkotas
jkotas approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VM side looks great!

SingleAccretion
SingleAccretion reviewed Jun 27, 2023
View reviewed changes
SingleAccretion
SingleAccretion reviewed Jun 27, 2023
View reviewed changes
@jkotas jkotas merged commit c88b377 into dotnet:main Jun 29, 2023
@EgorBo EgorBo mentioned this pull request Jul 6, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

+1 more reviewer

@SingleAccretion SingleAccretion SingleAccretion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichalPetryka @EgorBo @jkotas @SingleAccretion