Fix writing of WCHAR strings to event pipe buffer in nativeaot #88365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsAdd an overload of Tested manually by taking the part of #87785 for @LakshanF feel free to roll this into your PR and get rid of this one if you want Fixes #87978
|
|
I will close this PR and pull in this code to PR #87785 as you suggested, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an overload of
WriteToBufferspecifically for handlingconst WCHAR*(treating it as a string instead of a single value).Tested manually by taking the part of #87785 for
ExceptionThrown_V1(existing events before that PR don't have values of interest).@LakshanF feel free to roll this into your PR and get rid of this one if you want
Fixes #87978