Skip to content

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 12, 2023

Fixes #75970

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-GC-mono os-browser Browser variant of arch-wasm labels Jul 12, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 12, 2023
@pavelsavara pavelsavara self-assigned this Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

and see what happens #75970

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-GC-mono, os-browser

Milestone: 8.0.0

@pavelsavara

This comment was marked as outdated.

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

[FAIL] System.Runtime.CompilerServices.UnsafeTests.WriteUnaligned_ByRef_StructManaged

Log

Log AOT

[22:14:03] fail: Error: [MONO] D:/a/_work/1/s/src/mono/mono/metadata/object.c:926 <disabled>
    at at (http://127.0.0.1:49202/_framework/dotnet.runtime.js:3:18021)
    at it (http://127.0.0.1:49202/_framework/dotnet.runtime.js:3:18282)
    at wasm_trace_logger (wasm_trace_logger (http://127.0.0.1:49202/_framework/dotnet.native.wasm:wasm-function[55028]:0xadb51f))
    at eglib_log_adapter (eglib_log_adapter (http://127.0.0.1:49202/_framework/dotnet.native.wasm:wasm-function[42771]:0x8c712a))
    at monoeg_g_logv_nofree (monoeg_g_logv_nofree (http://127.0.0.1:49202/_framework/dotnet.native.wasm:wasm-function[42644]:0x8c2b14))
    at monoeg_g_log (monoeg_g_log (http://127.0.0.1:49202/_framework/dotnet.native.wasm:wasm-function[42646]:0x8c2be4))
    at g_log_disabled (g_log_disabled (http://127.0.0.1:49202/_framework/dotnet.native.wasm:wasm-function[42647]:0x8c2c1a))
    at compute_class_bitmap (compute_class_bitmap (http://127.0.0.1:49202/_framework/dotnet.native.wasm:wasm-function[45979]:0x9700e0))
    at mono_class_compute_gc_descriptor (mono_class_compute_gc_descriptor (http://127.0.0.1:49202/_framework/dotnet.native.wasm:wasm-function[45977]:0x96fc34))
    at instantiate_info (instantiate_info (http://127.0.0.1:49202/_framework/dotnet.native.wasm:wasm-function[47402]:0x9b8197))

I think this is unrelated to my PR, but I'm not sure. Both exhibitions above are on non-MT build, which this PR doesn't affect.

@kg @vargaz please advise

@vargaz
Copy link
Contributor

vargaz commented Jul 26, 2023

That should be fixed already.

@pavelsavara
Copy link
Member Author

I see #89417 thanks

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara requested a review from kg July 26, 2023 13:50
@pavelsavara pavelsavara marked this pull request as ready for review July 26, 2023 13:50
@pavelsavara
Copy link
Member Author

Debugger CI failures are unrelated

@pavelsavara pavelsavara merged commit 05d5656 into dotnet:main Jul 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
@pavelsavara pavelsavara deleted the browser_mt_gc branch September 2, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-GC-mono os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WASM] Check if we can still skip GC critical method check in WASM

4 participants