[interp] break up MINT_LDSTR_TOKEN into two opcodes #88738
Conversation
MINT_LDSTR_DYNAMIC for dynamic methods. the data item is an index into the DynamicMethod:method.method_data which stores pointers to MonoString objects that are held by the managed DynamicMethod. MINT_LDSTR_CSTR for ilgen wrappers. the data item is a raw C string that is global, or was allocated by malloc Fixes dotnet#88694 by allowing MINT_LDSTR_CSTR in any method since we no longer depend on mono_method_get_wrapper_data at execution time. And at transform time we have access to the actual wrapper method.
ghost
added
the
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsMINT_LDSTR_DYNAMIC for dynamic methods. the data item is an index into the DynamicMethod:method.method_data which stores pointers to MonoString objects that are held by the managed DynamicMethod. MINT_LDSTR_CSTR for ilgen wrappers. the data item is a raw C string that is global, or was allocated by malloc Fixes #88694 by allowing MINT_LDSTR_CSTR in any method since we no longer depend on mono_method_get_wrapper_data at execution time. And at transform time we have access to the actual wrapper method.
|
|
/cc @fanyang-mono this should make #88626 work without the |
|
The wbt failures here appear to be from a new sdk not these changes |
3 participants
MINT_LDSTR_DYNAMICfor dynamic methods. the data item is an index into theDynamicMethod:method.method_datawhich stores pointers toMonoStringobjects that are held by the managedDynamicMethod.MINT_LDSTR_CSTRfor ilgen wrappers. the data item is a raw C string that is global, or was allocated bymallocFixes #88694 by allowing
MINT_LDSTR_CSTRin any method since we no longer depend onmono_method_get_wrapper_dataat execution time. And at transform time we have access to the actual wrapper method.