Suppress Obsolete warnings in the ComInterfaceGenerator #88859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erate overrides of an calls to user-defined interface methods).
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsIn source-generated COM, we generate implementations of and calls to user-defined interface methods. If a user interface method is marked Obsolete, a warning was being issued. Follow how other source-generators handle this and ignore obsoletion warnings in source-generated code. Fixes #88813
|
jtschuster
approved these changes
Jul 13, 2023
AaronRobinsonMSFT
approved these changes
Jul 13, 2023
|
All failures are known, merging. |
This was referenced Jul 13, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In source-generated COM, we generate implementations of and calls to user-defined interface methods. If a user interface method is marked Obsolete, a warning was being issued. Follow how other source-generators handle this and ignore obsoletion warnings in source-generated code.
Fixes #88813