Skip to content

Fix EqualsIgnoreCaseUtf8_Scalar #89152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Fix EqualsIgnoreCaseUtf8_Scalar #89152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e182eb7
Fix EqualsIgnoreCaseUtf8_Scalar
EgorBo Jul 19, 2023
17ddfb6
revert change
EgorBo Jul 19, 2023
a06cdae
Merge branch 'main' of github.com:dotnet/runtime into fix-ordinal-utf8
EgorBo Jul 19, 2023
9230bc1
Remove activeissue
EgorBo Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/libraries/System.Private.CoreLib/src/System/Globalization/Ordinal.Utf8.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,13 +296,7 @@ internal static bool EqualsIgnoreCaseUtf8_Scalar(ref byte charA, int lengthA, re
return true;
}

if (!Utf8Utility.UInt32OrdinalIgnoreCaseAscii(valueAu32, valueBu32))
{
return false;
}

byteOffset += 4;
length -= 4;
return Utf8Utility.UInt32OrdinalIgnoreCaseAscii(valueAu32, valueBu32);
}

Debug.Assert(length == 0);
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Text.Json/tests/Common/NumberHandlingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,6 @@ async Task PerformFloatingPointSerialization(string testString)
[InlineData("\u0020Inf\u0069ni\u0074y")] // " Infinity"
[InlineData("\u002BInf\u0069nity")] // "+Infinity"
#pragma warning restore xUnit1025
[ActiveIssue("https://github.com/dotnet/runtime/issues/89094", TestPlatforms.OSX)]
public async Task FloatingPointConstants_Fail(string testString)
{
string testStringAsJson = $@"""{testString}""";
Expand Down