Skip to content

[browser] detect SIMD and EH support #89387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 25, 2023
Merged

[browser] detect SIMD and EH support #89387

merged 11 commits into from
Jul 25, 2023

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 24, 2023 •
edited
Loading

Use wasm-feature-detect library to detect wasm features and assert if they are missing.

Asserts with link to https://aka.ms/dotnet-wasm-features

Fixes #84574

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Jul 24, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 24, 2023
@pavelsavara pavelsavara requested a review from maraf July 24, 2023 14:18
@pavelsavara pavelsavara self-assigned this Jul 24, 2023
@pavelsavara pavelsavara requested review from kg and lewing as code owners July 24, 2023 14:18
@ghost
Copy link

ghost commented Jul 24, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Use wasm-feature-detect library to detect wasm features and assert if they are missing.

Fixes #84574

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, os-browser
Milestone: 8.0.0

@pavelsavara pavelsavara force-pushed the browser_detect_simd_eh branch from 91acd42 to 487f24a Compare July 24, 2023 14:21
@pavelsavara pavelsavara changed the title [browser] detect simd and EH support [browser] detect SIMD and EH support Jul 24, 2023
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89387 in repo dotnet/runtime

radekdoulik
radekdoulik approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jul 24, 2023
Closed
radical
radical reviewed Jul 24, 2023
View reviewed changes
radical
radical reviewed Jul 24, 2023
View reviewed changes
radical
radical reviewed Jul 24, 2023
View reviewed changes
radical
radical reviewed Jul 24, 2023
View reviewed changes
radical
radical reviewed Jul 24, 2023
View reviewed changes
This was referenced Jul 24, 2023
Closed
Closed
Closed
radical
radical reviewed Jul 24, 2023
View reviewed changes
@radical
Copy link
Member

radical commented Jul 24, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89387 in repo dotnet/runtime

@radical
Copy link
Member

radical commented Jul 24, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jul 25, 2023
Open
@pavelsavara
Copy link
Member Author

There is mono runtime already exited with 0 I created #89425 Log

@pavelsavara
Copy link
Member Author

pavelsavara commented Jul 25, 2023 •
edited
Loading

I realized that baking in the value of WasmEnableSIMD into dotnet.js loader in this PR will make this #89302 even more complex. Perhaps we need to solve it first. cc @radekdoulik

edit: #89433

@build-analysis build-analysis bot mentioned this pull request Jul 25, 2023
Closed
maraf
maraf approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@build-analysis build-analysis bot mentioned this pull request Jul 25, 2023
Closed
kg
kg reviewed Jul 25, 2023
View reviewed changes
@pavelsavara pavelsavara merged commit 764f774 into dotnet:main Jul 25, 2023
@build-analysis build-analysis bot mentioned this pull request Jul 25, 2023
Closed
@radekdoulik radekdoulik mentioned this pull request Jul 26, 2023
Open
@pavelsavara pavelsavara mentioned this pull request Jul 26, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
@pavelsavara pavelsavara deleted the browser_detect_simd_eh branch September 2, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical left review comments

@kg kg kg left review comments

@radekdoulik radekdoulik radekdoulik approved these changes

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[wasm] Make runtime errors from simd and exception handling failures easy to understand

5 participants

@pavelsavara @radical @kg @radekdoulik @maraf