Skip to content

[browser] remove active issue 77334 #89676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2023
Merged

[browser] remove active issue 77334 #89676

merged 2 commits into from
Aug 2, 2023

Conversation

@pavelsavara
Copy link
Member

I removed special handling of globalThis in mono_wasm_release_cs_owned_object in #88052

Hope this will fix #77334

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jul 29, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 29, 2023
@pavelsavara pavelsavara requested a review from kg July 29, 2023 16:58
@pavelsavara pavelsavara self-assigned this Jul 29, 2023
@ghost
Copy link

ghost commented Jul 29, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

I removed special handling of globalThis in mono_wasm_release_cs_owned_object in #88052

Hope this will fix #77334

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 8.0.0

@pavelsavara pavelsavara marked this pull request as ready for review August 2, 2023 11:35
@pavelsavara pavelsavara requested a review from lewing as a code owner August 2, 2023 11:35
@pavelsavara pavelsavara merged commit 2fdaae9 into dotnet:main Aug 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2023
@pavelsavara pavelsavara deleted the JsImportTaskTypes_take3 branch September 2, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kg kg kg approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[wasm] S.R.IS.JavaScript.Tests.JSImportExportTest.JsImportTaskTypes

2 participants

@pavelsavara @kg