Make ImplementsInterfaceOfSelf more precise for canonical subtypes #89969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
commented
Aug 3, 2023
| return true; | ||
| if (canonicalSubtype) | ||
| { | ||
| // Skip candidates that cannot possibly be the interface of self |
There was a problem hiding this comment.
This is the main part of the fix. Before this change, we have returned no value even for cases where we could have returned false.
The logic here needs to be at least as precise as the logic in TryResolveConstraintMethodApprox
runtime/src/coreclr/tools/Common/Compiler/TypeExtensions.cs
Lines 454 to 457 in 643087b
TryResolveConstraintMethodApprox from asserting when compiling potentially needed comparers.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 4, 2023
|
All failures are known |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89918