Support DllImportSearchPath.AssemblyDirectory for NativeAOT applications
#90120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on Windows. Reenable the NativeLibrary tests
directory when DllImportSearchPath.AssemblyDirectory is defined.
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFixes #89874
|
...System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.Windows.cs
Show resolved
Hide resolved
jkotas
reviewed
Aug 7, 2023
...tiveaot/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Aug 8, 2023
...System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.Windows.cs
Outdated
Show resolved
Hide resolved
...System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.Windows.cs
Outdated
Show resolved
Hide resolved
src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.csproj
Outdated
Show resolved
Hide resolved
src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.csproj
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Aug 8, 2023
...tiveaot/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.cs
Show resolved
Hide resolved
src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 8, 2023
|
Failures appear to be known. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89874