[release/7.0] [hot_reload] ignore modified MONO_TABLE_TYPEDEF rows in update #90167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dependencies from https://github.com/dotnet/xharness build 20230621.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 7.0.0-prerelease.23309.1 -> To Version 7.0.0-prerelease.23321.1 * Remove unnecessary spacing from conflict merge --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Carlos Sánchez López <[email protected]>
We may want to validate that Parent, Interfaces and Attributes columns haven't changed, but it's tricky and might be overly restrictive
…rt/pr-90166-to-release/7.0
|
I messed up the branches on this one. Going to try again. sorry. |
This was referenced Aug 8, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90166 to release/7.0
/cc @lambdageek
Customer Impact
Customers using Hot Reload with WebAssembly or mobile platforms should be able to delete custom attributes from classes in a hot reload session without the runtime crashing. Additionally customers using Blazor WebAssembly should be able to delete a
@layoutdirective without the runtime crashing.Testing
CI testing
Risk
Low. The PR removes an overeager validation check that assumed there hot reload deltas will not contain rows that modify existing types. However Roslyn does send such changes (although the modified row is logically equivalent to its previous value) when delete a custom attribute attached to a class. Note that custom attribute deletion was already working for fields and methods.