[wasm] Incremental build improvements #90194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
radical
force-pushed
the
wasm-incremental-build
branch
from
0eee015 to
22f2daa
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 11, 2023
- Check emcc versions *if* `EMSDK_PATH` was explicitly set, IOW, workloads are not in use
Convert the assemblies only if needed.
- If the inputs are older than the outputs, then no work needs to be
done
- The inputs consist of the assemblies to scan, and a list of pinvoke
modules.
- Timestamps are used for the assemblies
- And for the pinvoke modules list, we save that in a cache file, and
use that to determine if any work needs to be done.
`EmccCompile` task build compiles some `.c` files, but skips them if the output files are already up-to-date. But the build always emits a `Compiling native assets with emcc with ..` message, which suggests that there is some native build being run. Instead, emit this message only if `EmccCompile` actually did any work.
radical
force-pushed
the
wasm-incremental-build
branch
from
34390f4 to
dda5b20
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
reviewed
Aug 11, 2023
This was referenced Aug 11, 2023
|
Failures are unrelated. |
kg
reviewed
Aug 13, 2023
# Conflicts: # src/mono/wasm/Makefile
kg
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves build times ~30% for no-op rebuilds.
dotnetprocess running*webassembly.packwhich is the relevant package here.factorial.cfrom WebAssembly native dependency builds incrementalism is still slow #60245Fixes #60245 .