[mono] Enable floats in Vector128::ExtractMostSignificantBits on arm64 and amd64 #90304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 10, 2023
matouskozak
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
|
The failing CI lines are tracked and unrelated to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling emitting intrinsics for floating element types in
Vector128::ExtractMostSignificantBitson arm64 and amd64 architectures.Arm64
The
floatanddoubletypes are treated asintandlongtypes, respectively.Amd64
No changes were needed as the current implementation introduced in #89997 already handles floating element types correctly.
Contributes to #76025.