Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 16, 2023

Description

Backport of #90583 to release/8.0-rc1

This PR enables class loader runtime tests on android platforms on the CI.

Runtime tests for mobile targets are grouped into bundles, where each bundle contains multiple entry points. All assemblies are copied to the root directory of a given bundle on android platforms, meaning if two or more assemblies within one test group have the same names, one will overwrite the other, which could potentially lead to runtime errors.

The fix for this issue, an assembly is renamed to be unique in the test app bundle.

Customer Impact

The issue was discovered by a team member.

Testing

Manual testing and automated testing on the CI were performed, ensuring that the tests are passing on android platforms. The issue has been reproduced locally, and has been fixed.

Risk

Low risk. This change enables class loader runtime tests on android platforms on the CI.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

The change doesn't affect code that ships in a NuGet package.

@ghost ghost added the area-VM-meta-mono label Aug 16, 2023
@kotlarmilos kotlarmilos added Servicing-consider Issue for next servicing release review area-Infrastructure-mono and removed area-VM-meta-mono labels Aug 16, 2023
@ghost
Copy link

ghost commented Aug 16, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90583 to release/8.0-rc1

/cc @kotlarmilos

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-Infrastructure-mono

Milestone: -

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlossanlop this is just a test infrastructure change

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Aug 16, 2023
@kotlarmilos kotlarmilos self-assigned this Aug 16, 2023
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 16, 2023
@carlossanlop
Copy link
Contributor

CI failure is known:

@carlossanlop carlossanlop merged commit c96e5ab into release/8.0-rc1 Aug 16, 2023
@carlossanlop carlossanlop deleted the backport/pr-90583-to-release/8.0-rc1 branch August 16, 2023 20:14
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants