Skip to content

Fix Dispose and SendData Race on Http3 Test #91291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Fix Dispose and SendData Race on Http3 Test #91291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92cb18b
Fix Dispose and Send Data Race
liveans Aug 29, 2023
775920e
Review feedback
liveans Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,6 +1626,7 @@ public async Task DuplexStreaming_AbortByServer_StreamingCancelled(bool graceful
public async Task ServerSendsTrailingHeaders_Success()
{
using Http3LoopbackServer server = CreateHttp3LoopbackServer();
SemaphoreSlim clientFinishedSemaphore = new SemaphoreSlim(0);

Task serverTask = Task.Run(async () =>
{
Expand All @@ -1636,6 +1637,7 @@ public async Task ServerSendsTrailingHeaders_Success()
await requestStream.ReadRequestDataAsync();
await requestStream.SendResponseAsync(isFinal: false);
await requestStream.SendResponseHeadersAsync(null, new[] { new HttpHeaderData("MyHeader", "MyValue") });
await clientFinishedSemaphore.WaitAsync(TimeSpan.FromSeconds(20));
});

Task clientTask = Task.Run(async () =>
Expand All @@ -1655,6 +1657,7 @@ public async Task ServerSendsTrailingHeaders_Success()
(string key, IEnumerable<string> value) = Assert.Single(response.TrailingHeaders);
Assert.Equal("MyHeader", key);
Assert.Equal("MyValue", Assert.Single(value));
clientFinishedSemaphore.Release();
});

await new[] { clientTask, serverTask }.WhenAllOrAnyFailed(200_000);
Expand Down