[release/8.0] Options Source Gen Fixes #91432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsBackport of #91363 to release/8.0 /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
CC @jeffhandley |
jeffhandley
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
This is approved for RC2. It improves performance/quality of a new .NET 8 feature.
@carlossanlop to merge once CI completes
carlossanlop
added
Servicing-approved
This was referenced Sep 1, 2023
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90990
Fixes #91073
Backport of #91363 to release/8.0
/cc @tarekgh
Customer Impact
The options validation source generator was introduced in .NET 8.0. The changes made here serve to finalize this feature while addressing reliability and performance issues.
Randomin the source generator and instead use the module name hash. Options source generator shouldn't use random names #90990!when callingValidator.TryValidateValueIEnumerable<T>and tagged with the attributeValidateEnumeratedItemsTesting
Regression tests in addition to adding more tests to cover the newly introduced scenarios.
Risk
While the modifications did introduce some minor alterations to the generated code, they did not impact the underlying logic of how the generated code functions, except for addressing the listed issues. There were no significant revisions made to the source generator itself.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.