Remove "Is supported on this TFM" logic from marshalling generators and instead handle it during factory construction #91768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't build for .NET 6 or 7 in dotnet/runtime any more, so we don't need to include this marshalling logic.
…enerator factory. Also, do a first step disabling the legacy SafeHandleMarshaller logic instead of making it work just to remove it.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThe only generator that supports down-level is the LibraryImportGenerator, so remove this infrastructure from the base APIs and instead have LibraryImportGenerator create a different generator factory depending on the TFM. Also, include #91765 as we would have had to separate out the legacy SafeHandle marshaller instantiation to a separate marshalling generator factory, but we don't use it anyway any more.
|
ghost
assigned
jtschuster
approved these changes
Sep 11, 2023
...ibraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.cs
Outdated
Show resolved
Hide resolved
…Generator/LibraryImportGenerator.cs Co-authored-by: Jackson Schuster <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only generator that supports down-level is the LibraryImportGenerator, so remove this infrastructure from the base APIs and instead have LibraryImportGenerator create a different generator factory depending on the TFM.
Also, include #91765 as we would have had to separate out the legacy SafeHandle marshaller instantiation to a separate marshalling generator factory, but we don't use it anyway any more.