Skip to content

JIT: Fix case where we illegally optimize away a memory barrier on ARM32 #91827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

JIT: Fix case where we illegally optimize away a memory barrier on ARM32 #91827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/jit/emitarm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4848,6 +4848,7 @@ void emitter::emitIns_Call(EmitCallType callType,

dispIns(id);
appendToCurIG(id);
emitLastMemBarrier = nullptr; // Cannot optimize away future memory barriers
}

/*****************************************************************************
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8908,6 +8908,7 @@ void emitter::emitIns_Call(EmitCallType callType,

dispIns(id);
appendToCurIG(id);
emitLastMemBarrier = nullptr; // Cannot optimize away future memory barriers
Copy link
Member Author

@jakobbotsch jakobbotsch Sep 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this entire peephole should be switched to use the new backwards traversal peephole mechanism, which I expect would have quite significant TP improvements as we currently have code in very hot appendToCurIG to handle this peephole. I've opened #91825 to track that. However, given that this PR should be backported I've kept the fix here surgical.

}

/*****************************************************************************
Expand Down