Skip to content

Conversation

@vseanreesermsft
Copy link

No description provided.

dotnet-bot and others added 14 commits August 1, 2023 22:25
This prevents using unlimited resources from evil sources.
I originally wanted to split limits and have them separately for certificates, OCSP and CRLs.
However, the HttpClient.MaxResponseContentBufferSize can be set only once so I decided to keep it simple for servicing.

We could split the HttpClient and have one for small and one for large downloads.
Or alternatively we can handle the body directly. But it is going to be unpleseant with the reflection and sync & async flavors.

port of https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/pullrequest/32920
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 12, 2023
@ghost ghost assigned vseanreesermsft Sep 12, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 12, 2023
@carlossanlop
Copy link
Contributor

@hoyosjs there's a CI failure affecting several legs:

error NU1603: (NETCORE_ENGINEERING_TELEMETRY=Restore) externals depends on Microsoft.DiaSymReader.Native (>= 16.11.29-beta1.23404.4) but Microsoft.DiaSymReader.Native 16.11.29-beta1.23404.4 was not found. An approximate best match of Microsoft.DiaSymReader.Native 17.0.0-beta1.21524.1 was resolved.

@carlossanlop carlossanlop merged commit feffbcc into dotnet:release/7.0 Sep 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants