[mono][wasm] Only catch the exception thrown by mono_llvm_cpp_throw_e… #92040
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
kg
reviewed
Sep 14, 2023
vargaz
force-pushed
the
wasm-catch
branch
2 times, most recently
from
024d620 to
60cca14
Compare
…xception() in AOT-ed code. Part of the fix for dotnet#90692.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| LLVMValueRef args [] = { catchpad }; | ||
| LLVMValueRef call = call_intrins (ctx, INTRINS_WASM_GET_EXCEPTION, args, ""); | ||
| LLVMSetTailCall (call, TRUE); |
There was a problem hiding this comment.
I am pretty sure there is no need for the tail annotation and Clang just adds it because that's what it does for most calls.
|
We may want to backport this to 8.0 staging. (I thought this fix was already in 8, but it looks like it's not?) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xception() in AOT-ed code.
Part of the fix for #90692.