Fix support of FromKeyedServicesAttribute in ActivatorUtilities.CreateFactory #92082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92076
Right now
ActivatorUtilities.CreateFactorydoesn't check if the constructor parameters have aFromKeyedServicesAttributeto get them from the keyed services container.It will make
ActivatorUtilities.CreateFactoryslower since it involves more reflection, butCreateFactoryshould be called only once per type, and the factory created can be cached and called multiple times by the application, so it should not impact performance too much.ASP.NET Core MVC and SignalR need this feature for 8.0.