Ensure that embedded broadcast checks the base type of the parent node #92414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
This ensures that we check both the base type of the broadcast (which indicates how many bytes it reads from memory) and the base type of the parent node (which indicates how many bytes it would read from memory).
|
jakobbotsch
reviewed
Sep 21, 2023
jakobbotsch
approved these changes
Sep 21, 2023
|
/backport to release/8.0-rc2 |
|
Started backporting to release/8.0-rc2: https://github.com/dotnet/runtime/actions/runs/6270127035 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsContainableHWIntrinsicOpwas only checking the base type of the broadcast node, which meant that scenarios such asMultiplyLow(vector256Int16, Vector256.Create(int32).AsInt16())would incorrectly try to contain the child node.This ensures that we check both the base type of the broadcast (which indicates how many bytes it reads from memory) and the base type of the parent node (which indicates how many bytes it would read from memory).