Skip to content

Light up String.Manipulation APIs with Vector512 codepath #92579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Light up String.Manipulation APIs with Vector512 codepath #92579

wants to merge 8 commits into from

Conversation

@khushal1996
Copy link
Member

@khushal1996 khushal1996 commented Sep 25, 2023 •
edited
Loading

NO NEED FOR REVIEW AT THIS TIME. STILL A WIP

Optimizing the following String APIs

  1. String.Replace(string old, string replacer) --> Optimization done for cases where oldValue.Length ==1 and newValue.Length != 1
  2. String.Split --> Optimizing MakeSeparatorListVectorized
  3. String.Replace(char oldChar, char newChar) --> Optimizing for first iteration

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners community-contribution Indicates that the PR has been added by a community member labels Sep 25, 2023
@build-analysis build-analysis bot mentioned this pull request Sep 27, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Sep 28, 2023
Closed
@khushal1996
Moving the implementation out of current function as a static functio…
806b7ee 
…n and removing PackedSpanHelper from the call
@khushal1996 khushal1996 closed this Oct 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@khushal1996