Skip to content

Conversation

@steveisok
Copy link
Member

Work in conjunction with #92645. Instead of trimming on build machine, do it on helix.

@ghost ghost assigned steveisok Sep 27, 2023
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 27, 2023
@steveisok
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member

I'm currently working on trimming for the runtime tests. It might be good to wait for this to be merged before proceeding. Assuming that the publish is done on build machine, how do you plan to invoke the trimmer?

I tried to hook it into the pipeline after the build target, which is the default one for the runtime tests, but it seems the PrepareForILLink has an indirect dependency on one of the publish targets (_ComputeAssembliesToPostprocessOnPublish).

@steveisok
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost closed this Nov 8, 2023
@ghost
Copy link

ghost commented Nov 8, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants