[release/8.0] Resolve x64 libc++ being included with linux-arm64 to browser-wasm cross-compiler #93070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2023 13:45
…wasm cross-compilers, due to incorrect assumption that the build architecture should be used for wasm cases. Closes: #93015
directhex
changed the title
marek-safar
approved these changes
Oct 5, 2023
3 tasks
steveisok
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93027 to release/8.0
/cc @directhex
Customer Impact
As-is, AOT of browser-wasm workloads on linux-arm64 will fail unless a sufficiently new OS-provided build of libc++ is installed. This patch mitigates that need.
Testing
Internal build on main in https://dev.azure.com/dnceng/internal/_build/results?buildId=2283866&view=results
Risk