Fix a memory leak in runtime interop stubs when using an array of structs of types that use old-style managed marshalers #93089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… poniter to the managed field with a null pointer instead of skipping the ClearNative call.
ghost
assigned
|
Can we write a test for this? |
|
I have an idea for one. I'll try it out tomorrow. |
…ate lifetimes. We can't use ICustomMarshaler here as that isn't supported in field scenarios.
|
@jkotas I've constructed a test using the "Fixed Array" marshaller with a COM object to give me a testable lifetime hook. Sadly my initial idea of using |
This was referenced Oct 6, 2023
jkotas
reviewed
Oct 7, 2023
src/tests/Interop/ArrayMarshalling/StructArray/MarshalStructArrayTest.cs
Outdated
Show resolved
Hide resolved
src/tests/Interop/ArrayMarshalling/StructArray/MarshalStructArrayTest.cs
Outdated
Show resolved
Hide resolved
src/tests/Interop/ArrayMarshalling/StructArray/MarshalStructArrayTest.cs
Outdated
Show resolved
Hide resolved
|
@jkoritzinsky Can you also please run this test a dozen times or so on a Checked build with |
…rayTest.cs Co-authored-by: Aaron Robinson <[email protected]>
|
Validated that the test passes with GCStress=C. |
jkotas
reviewed
Oct 9, 2023
src/tests/Interop/ArrayMarshalling/StructArray/MarshalStructArrayTest.cs
Show resolved
Hide resolved
jkotas
reviewed
Oct 9, 2023
src/tests/Interop/ArrayMarshalling/StructArray/MarshalStructArrayTest.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 9, 2023
src/tests/Interop/ArrayMarshalling/StructArray/MarshalStructArrayNative.cpp
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Oct 9, 2023
…we are testing and how we are testing it as it is very much not straightfoward.
jkotas
reviewed
Oct 9, 2023
src/tests/Interop/ArrayMarshalling/StructArray/MarshalStructArrayNative.cpp
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 9, 2023
src/tests/Interop/ArrayMarshalling/StructArray/MarshalStructArrayTest.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we don't have a managed value in a ClearNative call, the managed pointer to the managed field with a null pointer instead of skipping the ClearNative call.
The initial approach was taken in dotnet/coreclr#27562 to avoid bad GC pointers, but this approach also avoids bad GC pointers and correctly frees the memory.
Validated locally. I'm also going to validate offline with a 1st-party customer that reported this issue and then backport to 6.0-8.0.