SPMI: Fix 'misses' fraction computation and calculate total contexts correctly #93179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakobbotsch
commented
Oct 7, 2023
jakobbotsch
commented
- The misses fraction was computed as misses / diffed, which can produce odd results (such as > 100% of contexts being misses). Compute it as misses / total.
- Fix a few places computing total contexts as "successful + failing". After the recent aggregation change the "failing" category no longer includes misses, so this has been updated to "successful + failing + misses".
- Aggregate "diffed contexts" as we want this in a few places (previously it was approximated as "successful compiles" in the diff, which is usually the same thing, but not exactly)
- Remove a bunch of unnecessary int(x) calls after recent changes to do aggregation in superpmi.py
…correctly * The misses fraction was computed as misses / diffed, which can produce odd results (such as > 100% of contexts being misses). Compute it as misses / total. * Fix a few places computing total contexts as "successful + failing". After the recent aggregation change the "failing" category no longer includes misses, so this has been updated to "successful + failing + misses". * Aggregate "diffed contexts" as we want this in a few places (previously it was approximated as "successful compiles" in the diff, which is usually the same thing, but not exactly) * Remove a bunch of unnecessary int(x) calls after recent changes to do aggregation in superpmi.py
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
|
Member
Author
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall |
BruceForstall
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.