[wasm] Use the KnownFrameworkReference update to change the targeting pack #93625
+4
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @directhex Issue Detailsnull
|
lewing
force-pushed
the
test-targeting
branch
from
66e1e72 to
b2304ba
Compare
lewing
force-pushed
the
test-targeting
branch
from
b2304ba to
4a7e852
Compare
radical
reviewed
Oct 18, 2023
| <!-- Overrides for wasm threading support --> | ||
| <RuntimePackNamePatterns Condition="'$(RuntimeIdentifier)' == 'browser-wasm' and '$(WasmEnableThreads)' == 'true'">Microsoft.NETCore.App.Runtime.Mono.multithread.**RID**</RuntimePackNamePatterns> | ||
| </KnownRuntimePack> | ||
| <KnownFrameworkReference Update="Microsoft.NETCore.App"> |
Member
There was a problem hiding this comment.
not for this pr, but we should have the same thing for net8 also.
radical
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the first step but it is my feeling that we should update all the things used in ProcessFrameworkReferences (that come from runtime) with the version from runtime by default