Skip to content

[mono][tests] Disable CustomGeneratedAttributes test on linux-bionic #93724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[mono][tests] Disable CustomGeneratedAttributes test on linux-bionic #93724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
748c9c4
Disable failing test
kotlarmilos Oct 19, 2023
4a04203
Add missing [
kotlarmilos Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ies/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/OptionsRuntimeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ public void TestNewDataAnnotationFailures()
}, result.Failures);
}
#endif // NET8_0_OR_GREATER

[SkipOnPlatform(TestPlatforms.LinuxBionic, "https://github.com/dotnet/runtime/issues/93723")]
Copy link
Member

@steveisok steveisok Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever reason, this doesn't seem to be respected on the latest CI run

Copy link
Member Author

@kotlarmilos kotlarmilos Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, here is the latest run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=444522&view=logs&j=8ce12db4-5178-5d5b-6012-cb5f9bb20b0f.

Closing this PR. If the same error is encountered we will reopen it.

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBrowser))]
public void TestCustomGeneratedAttributes()
{
Expand Down