Skip to content

Merge remaining JIT tests #94444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 29, 2023
Merged

Merge remaining JIT tests #94444

merged 11 commits into from
Dec 29, 2023

Conversation

@trylek
Copy link
Member

@trylek trylek commented Nov 7, 2023

No description provided.

@trylek trylek requested a review from markples November 7, 2023 00:23
@ghost
Copy link

ghost commented Nov 7, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: trylek
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@ghost ghost assigned trylek Nov 7, 2023
@trylek
Copy link
Member Author

trylek commented Nov 7, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Nov 7, 2023
Closed
markples
markples reviewed Nov 8, 2023
View reviewed changes
markples
markples reviewed Nov 8, 2023
View reviewed changes
markples
markples reviewed Nov 8, 2023
View reviewed changes
@trylek trylek force-pushed the MergeRemainingJitTests branch from 8622340 to ccbd962 Compare December 20, 2023 15:28
@build-analysis build-analysis bot mentioned this pull request Dec 20, 2023
Closed
@trylek
Copy link
Member Author

trylek commented Dec 20, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trylek trylek force-pushed the MergeRemainingJitTests branch from ccbd962 to e0914cd Compare December 28, 2023 19:11
@trylek trylek requested a review from jkoritzinsky December 28, 2023 19:13
@trylek
Copy link
Member Author

trylek commented Dec 28, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky
jkoritzinsky approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mechanical conversion looks good. I agree with Mark's comments, but otherwise LGTM.

@trylek trylek merged commit e6a15a0 into dotnet:main Dec 29, 2023
@trylek trylek deleted the MergeRemainingJitTests branch December 29, 2023 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

+1 more reviewer

@markples markples markples left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@trylek trylek

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek @jkoritzinsky @markples