Handle platform not supported during test discovery. #94844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Browser is doing test discovery, it now more eagerly reads some static initialization that we were previously depending on conditionals preventing. This changes the initialization to handle platform not supported in more scenarios.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsWhen Browser is doing test discovery, it now more eagerly reads some static initialization that we were previously depending on conditionals preventing. This changes the initialization to handle platform not supported in more scenarios. Fixes #94820
|
|
/azp list |
This comment was marked as outdated.
This comment was marked as outdated.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adamsitnik
approved these changes
Nov 16, 2023
This was referenced Nov 16, 2023
bartonjs
approved these changes
Nov 16, 2023
This was referenced Nov 20, 2023
lewing
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Browser is doing test discovery, it now more eagerly reads some static initialization that we were previously depending on conditionals preventing.
This changes the initialization to handle platform not supported in more scenarios.
Fixes #94820