Skip to content

Conversation

@a74nh
Copy link
Contributor

@a74nh a74nh commented Nov 20, 2023

Many of the files touched here are autogenerated via InstructionSetDesc.txt. In addition adds config options plus an empty hwintrinsiclistarm64sve.h

This is #94791 without the library API changes.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Nov 20, 2023
@ghost
Copy link

ghost commented Nov 20, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

#94791 without the library API changes.

Author: a74nh
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@a74nh a74nh changed the title Add SVE instruction set for Arm64 Add SVE InstructionSet for Arm64 Nov 20, 2023
@a74nh a74nh marked this pull request as ready for review November 20, 2023 17:16
@a74nh
Copy link
Contributor Author

a74nh commented Nov 20, 2023

@kunalspathak

@kunalspathak
Copy link
Contributor

@dotnet/jit-contrib

@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Nov 20, 2023
@kunalspathak
Copy link
Contributor

plus an empty hwintrinsiclistarm64sve.h

IMO we don't have to include this file and related changes in this PR.

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus an empty hwintrinsiclistarm64sve.h

IMO we don't have to include this file and related changes in this PR. They are not necessary to add just the InstructionSet portion.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Nov 20, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Nov 21, 2023
@a74nh
Copy link
Contributor Author

a74nh commented Nov 21, 2023

plus an empty hwintrinsiclistarm64sve.h

IMO we don't have to include this file and related changes in this PR. They are not necessary to add just the InstructionSet portion.

Ok, removed.

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kunalspathak
Copy link
Contributor

cc: @jkotas

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas jkotas merged commit f1ee7ce into dotnet:main Nov 21, 2023
@a74nh a74nh deleted the sve_coreclr_api branch December 6, 2023 10:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants