[browser] JSImport binding improvements #95177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assign ImportHandle in C# side, not is JS side detect if method are async with signature.IsAsync detect fi parameters have thread affinity with signature.IsThreadCaptured made all task.ContinueWith static rename JSSynchronizationContext.TargetThreadId to TargetTID rename BindJSFunction to BindJSImport rename InvokeImport to InvokeJSImport rename mono_wasm_bind_js_function to mono_wasm_bind_js_import rename mono_wasm_invoke_import to mono_wasm_invoke_js_import drop parameter InstallWebWorkerInterop, always install full EmitCompilerGeneratedFiles in debug mode for few projects
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Other
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maraf
reviewed
Nov 24, 2023
...ropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.cs
Outdated
Show resolved
Hide resolved
...ervices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSSynchronizationContext.cs
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
…stem/Runtime/InteropServices/JavaScript/JSHostImplementation.cs Co-authored-by: Marek Fišera <[email protected]>
…a/runtime into browser_jsimport_bind
31 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for better MT dispatch.
function_nameandmodule_namepart of the import signature buffersignature.IsAsyncsignature.IsThreadCapturedtask.ContinueWithstaticOther
JSSynchronizationContext.TargetThreadIdtoTargetTIDBindJSFunctiontoBindJSImportInvokeImporttoInvokeJSImportmono_wasm_bind_js_functiontomono_wasm_bind_js_importmono_wasm_invoke_importtomono_wasm_invoke_js_importInstallWebWorkerInterop, always install full<EmitCompilerGeneratedFiles>in debug mode for few projects