[release/8.0-staging] Add JSON null support for the built-in (ReadOnly)Memory converters. #95325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsBackport of #95275 to release/8.0-staging /cc @eiriktsarpalis Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
eiriktsarpalis
added
the
Servicing-consider
stephentoub
approved these changes
Nov 28, 2023
jozkee
approved these changes
Nov 28, 2023
tarekgh
approved these changes
Nov 28, 2023
jeffhandley
approved these changes
Nov 28, 2023
eiriktsarpalis
added
Servicing-approved
Member
|
Approved over email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #95275 to release/8.0-staging
/cc @eiriktsarpalis
Customer Impact
.NET 8 saw the inclusion of new built-in converters for
Memory<T>andReadOnlyMemory<T>types. These converters will throw an exception on deserialization if given anullJSON value. While this behavior is consistent with other non-nullable struct types, we feel that it should be tweaked forMemorytypes since they allow implicit conversion fromnullin .NET code. The change is being backported to .NET 8 since SK adoption of the new built-in converters is blocked because of this issue.Testing
Added unit tests covering the newly added behavior.
Risk
Low. Adds null handling functionality to the specific built-in converers.