Skip to content

make WritingShouldUpdateWriteTime_After_SetLastAccessTime more resilient #95336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023
Merged

make WritingShouldUpdateWriteTime_After_SetLastAccessTime more resilient #95336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993882e
increase the delay to see if it's resolution issue
adamsitnik Nov 28, 2023
66c3bfe
simplify the test and add a retry loop
adamsitnik Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions ...raries/System.Runtime/tests/System.IO.FileSystem.Tests/File/GetSetTimes_SafeFileHandle.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,19 +96,23 @@ protected override DateTime GetLastWriteTimeUtc(string path)
public async Task WritingShouldUpdateWriteTime_After_SetLastAccessTime()
{
string filePath = GetTestFilePath();
using var handle = OpenFileHandle(filePath, FileAccess.ReadWrite);
using SafeFileHandle handle = OpenFileHandle(filePath, FileAccess.ReadWrite);

File.SetLastAccessTime(handle, DateTime.Now.Subtract(TimeSpan.FromDays(1)));
var timeBeforeWrite = File.GetLastWriteTime(handle);
DateTime timeAfterWrite = default, timeBeforeWrite = File.GetLastWriteTime(handle);

using var writer = new StreamWriter(new FileStream(handle, FileAccess.ReadWrite));
writer.AutoFlush = true;
writer.WriteLine("now: " + DateTime.Now);
await Task.Delay(2000);
writer.WriteLine("now: " + DateTime.Now);
// According to https://learn.microsoft.com/en-us/windows/win32/api/fileapi/ns-fileapi-win32_file_attribute_data
// write time has a resolution of 2 seconds on FAT. Let's wait a little bit longer.
for (int i = 0; i <= 5 && timeBeforeWrite >= timeAfterWrite; i++)
{
await Task.Delay(TimeSpan.FromSeconds(i));

var timeAfterWrite = File.GetLastWriteTime(handle);
Assert.True(timeAfterWrite > timeBeforeWrite);
await RandomAccess.WriteAsync(handle, new byte[1] { 1 }, fileOffset: i);

timeAfterWrite = File.GetLastWriteTime(handle);
}

AssertExtensions.GreaterThan(timeAfterWrite, timeBeforeWrite);
}

[Fact]
Expand Down