Skip to content

[browser][MT] Use auto thread dispatch in HTTP #95370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 21, 2024
Merged

[browser][MT] Use auto thread dispatch in HTTP #95370

merged 25 commits into from
Jan 21, 2024

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Nov 28, 2023 •
edited
Loading

HTTP

  • are now using automatic dispatch to correct thread via [browser][MT] JSImport dispatch to target thread via JSSynchronizationContext #96319
  • are modified to be bit more thread safe and also to not deadlock
  • introduced HttpController helper object on the JavaScript side
  • unified http_wasm_transform_stream_abort into regular abort. Abort request will also abort response if any.
  • renamed WasmFetchResponse to BrowserHttpController
    • moved CallFetch and header construction logic to it.
    • simplified logic of awaiting closePromise and fetchPromise and observing the errors
  • renamed WasmHttpWriteStream to BrowserHttpWriteStream
  • added new unit test into WebWorkerTest which test client usage across thread boundaries.
  • added MT HTTP test to MT smoke tests
  • System.Net.Http.Functional.Tests, now also run xunit on thread pool in MT

Other

  • simplified JSWebWorker
  • fixed setup_proxy_console for early disconnect
  • dropped SynchronizationContextExtension
  • dropped JSHost.CurrentOrMainJSSynchronizationContext

Fixes #96173
Fixes #75123

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Nov 28, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Nov 28, 2023
@pavelsavara pavelsavara requested a review from maraf November 28, 2023 23:40
@pavelsavara pavelsavara self-assigned this Nov 28, 2023
@ghost
Copy link

ghost commented Nov 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

This was referenced Nov 30, 2023
Closed
Open
Closed
Closed
@pavelsavara pavelsavara mentioned this pull request Nov 30, 2023
Merged
@pavelsavara pavelsavara force-pushed the browser_jsimport_sc_dispatch branch 2 times, most recently from 3cf1400 to 6c3bf7f Compare December 4, 2023 20:56
@build-analysis build-analysis bot mentioned this pull request Dec 5, 2023
Closed
@pavelsavara

This comment was marked as outdated.

Sign in to view
@build-analysis build-analysis bot mentioned this pull request Dec 6, 2023
Closed
@pavelsavara pavelsavara force-pushed the browser_jsimport_sc_dispatch branch 2 times, most recently from ec2fc61 to 730b5ec Compare December 12, 2023 13:32
@build-analysis build-analysis bot mentioned this pull request Dec 12, 2023
Closed
@pavelsavara pavelsavara force-pushed the browser_jsimport_sc_dispatch branch 2 times, most recently from 8b6ae1e to b22f15c Compare December 16, 2023 21:17
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

This comment was marked as outdated.

Sign in to view
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Dec 19, 2023
Open
@build-analysis build-analysis bot mentioned this pull request Jan 19, 2024
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 19, 2024
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jan 20, 2024
Closed
@pavelsavara
Copy link
Member Author

There is [11:24:42] fail: Application has finished with exit code TIMED_OUT but 0 was expected in System.Runtime.InteropServices.JavaScript.Tests
Log

I will work on it as part of #96628

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

CI failures are
#97217
thread join issue from #96628
and some random infra issue with System.Net.Mail.Unit.Tests Log

@pavelsavara pavelsavara merged commit 756a138 into dotnet:main Jan 21, 2024
@pavelsavara pavelsavara deleted the browser_jsimport_sc_dispatch branch January 21, 2024 10:39
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@pavelsavara @campersau
@maraf @tmds
[browser][MT] Use auto thread dispatch in HTTP (dotnet#95370)
f07039b 
Co-authored-by: campersau <[email protected]>
Co-authored-by: Marek Fišera <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

@kg kg Awaiting requested review from kg

+1 more reviewer

@campersau campersau campersau left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

[browser][MT] deadlock in BrowserWebSocket when used from multiple threads [browser][MT] System.Xml.Tests.TC_SchemaSet_Add_URL.v4

4 participants

@pavelsavara @kg @campersau @maraf