Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 7, 2023

Backport of #90948 to release/8.0-staging

/cc @MichalStrehovsky @agocke

Customer Impact

Combining <EventSourceSupport>true</EventSourceSupport> with <ControlFlowGuard>guard</ControlFlowGuard> results in a build failure because we forgot to ship the necessary static library.

Testing

We've been building this library in the main branch since August.

Risk

This is just an extra file to put in a NuGet package. The risk is close to zero.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Dec 7, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90948 to release/8.0-staging

/cc @MichalStrehovsky @agocke

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Dec 9, 2023
@jeffschwMSFT jeffschwMSFT added this to the 8.0.2 milestone Dec 9, 2023
@MichalStrehovsky
Copy link
Member

@LakshanF regarding the extra commits - what's the testing strategy for this in main? E.g. are you going to submit that commit as a PR for main as well?

@LakshanF
Copy link
Contributor

LakshanF commented Dec 11, 2023

@LakshanF regarding the extra commits - what's the testing strategy for this in main? E.g. are you going to submit that commit as a PR for main as well?

Yes, I'm planning to add ControlFlowGuard property to some tests on the nativeAOT outer loop CI run that I'm working on currently (#95039). We are no longer running the CoreCLR tracing tests in nativeAOT regular CI runs in the main branch (post net8) due to time constraints.

@MichalStrehovsky
Copy link
Member

We are no longer running the CoreCLR tracing tests in nativeAOT regular CI runs in the main branch (post net8) due to time constraints.

I don't understand - we run EventPipe testing in regular rolling builds. They run as part of the CoreCLR Native AOT pri-0 run about twice a day. Pulling these commits into main would ensure we have coverage in main as well. What am I missing?

@jeffschwMSFT jeffschwMSFT merged commit 758ae99 into release/8.0-staging Jan 2, 2024
@jkotas jkotas deleted the backport/pr-90948-to-release/8.0-staging branch January 2, 2024 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-NativeAOT-coreclr Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants