-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/8.0-staging] Add CFG build for EventPipe enabled #95721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Add CFG build for EventPipe enabled #95721
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #90948 to release/8.0-staging Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 8.0.x
|
@LakshanF regarding the extra commits - what's the testing strategy for this in |
Yes, I'm planning to add |
I don't understand - we run EventPipe testing in regular rolling builds. They run as part of the CoreCLR Native AOT pri-0 run about twice a day. Pulling these commits into main would ensure we have coverage in main as well. What am I missing? |
Backport of #90948 to release/8.0-staging
/cc @MichalStrehovsky @agocke
Customer Impact
Combining
<EventSourceSupport>true</EventSourceSupport>with<ControlFlowGuard>guard</ControlFlowGuard>results in a build failure because we forgot to ship the necessary static library.Testing
We've been building this library in the main branch since August.
Risk
This is just an extra file to put in a NuGet package. The risk is close to zero.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.