Set s_naiveThreshold to const in the release build.
#96538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsAnother source uses the following idiom. I have adapted it. #if DEBUG
// Mutable for unit testing...
private static
#else
private const
#endif
|
kzrnm
force-pushed
the
fix/BigIntegerDebugConst
branch
from
bb6ad16 to
113f210
Compare
This was referenced Jan 5, 2024
src/libraries/System.Runtime.Numerics/src/System/Number.BigInteger.cs
Outdated
Show resolved
Hide resolved
kzrnm
force-pushed
the
fix/BigIntegerDebugConst
branch
from
113f210 to
94fc74f
Compare
kzrnm
force-pushed
the
fix/BigIntegerDebugConst
branch
from
94fc74f to
8fa4a35
Compare
tannergooding
approved these changes
Jan 5, 2024
This was referenced Jan 9, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another source uses the following idiom. I have adapted it.
runtime/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.Utils.cs
Lines 8 to 14 in 9e31c21
runtime/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.SquMul.cs
Lines 13 to 19 in 9e31c21