Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Jan 15, 2024

v1.8.0, see libunwind-version.txt.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Reflection.Metadata labels Jan 15, 2024
@ghost
Copy link

ghost commented Jan 15, 2024

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

v1.8.0, see libunwind-version.txt.

Author: am11
Assignees: -
Labels:

area-System.Reflection.Metadata, community-contribution

Milestone: -

@am11
Copy link
Member Author

am11 commented Jan 15, 2024

arm64 legs are currently hitting a syntax error in inline asm (clang vs. gcc thing). Filed libunwind/libunwind#702.

@am11
Copy link
Member Author

am11 commented Jan 18, 2024

Revert libunwind/libunwind#503 # issue: libunwind/libunwind#702

Added this note in libunwind-version.txt. I had to revert that assembly change since this it was causing build issue with aarch64-clang (which doesn't allow more than 14 registers without using temps -> the version after the revert).

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking care of these updates!

@janvorli janvorli merged commit 5bb5840 into dotnet:main Jan 19, 2024
@janvorli
Copy link
Member

The failed legs were unrelated to this PR (windows x86, wasm)

tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
* Update libunwind to v1.8.0

* Add HAVE_PIPE2 definition

* Revert "Rework register load in aarch64_local_resume()"

libunwind/libunwind@08bc8c0

* Update Gos-linux.c

* Update libunwind-version.txt
hoyosjs added a commit that referenced this pull request Jan 30, 2024
hoyosjs added a commit that referenced this pull request Jan 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants