Skip to content

Revert "[browser][HybridGlobalization] Improve speed performance of IndexOf and LastIndexOf text APIs with HybridGlobalization mode" #97035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "[browser][HybridGlobalization] Improve speed performance of IndexOf and LastIndexOf text APIs with HybridGlobalization mode" #97035

wants to merge 1 commit into from

Conversation

@matouskozak
Copy link
Member

Reverts #95583

Build of browser-wasm linux Release LibraryTests_AOT is timining-out due to this PR.

@matouskozak
Revert "[browser][HybridGlobalization] Improve speed performance of I…
4fe0166 
…ndexOf and LastIndexOf text APIs with HybridGlobalization mode"
@ghost ghost added the area-Build-mono label Jan 16, 2024
@ghost ghost assigned matouskozak Jan 16, 2024
@ilonatommy ilonatommy requested a review from SamMonoRT January 16, 2024 16:24
@matouskozak
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matouskozak
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 16, 2024
Open
Closed
@radical
Copy link
Member

radical commented Jan 16, 2024

The EAT/AOT builds have been timing out in the last few days. I just opened #97044 for it. Does the HG PR cause failure even without the existing issue?

@matouskozak matouskozak added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 17, 2024
@matouskozak
Copy link
Member Author

matouskozak commented Jan 17, 2024 •
edited
Loading

The EAT/AOT builds have been timing out in the last few days. I just opened #97044 for it. Does the HG PR cause failure even without the existing issue?

It looks like the AOT build is timing out even here with the revert. I was testing it in a separate PR and it was timing out with #95583 (https://dev.azure.com/dnceng-public/public/_build/results?buildId=528555&view=logs&j=58dc7ccb-0414-5dd3-62a5-bf2e63258b7c) and it wasn't after reverting it (https://dev.azure.com/dnceng-public/public/_build/results?buildId=528758&view=results). Based on that, I concluded that it was caused by #95583 but now it looks like the time-out is not deterministic.

I was watching the logs before time-out, and this was the last message from Build product
image

@jkotas jkotas deleted the revert-95583-wasm-hg-indexOf branch January 20, 2024 03:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SamMonoRT SamMonoRT SamMonoRT approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@radical radical Awaiting requested review from radical

@marek-safar marek-safar Awaiting requested review from marek-safar

+1 more reviewer

@vargaz vargaz vargaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matouskozak matouskozak

Labels

area-Build-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matouskozak @radical @vargaz @SamMonoRT