Forward minipal_get_length_utf16_to_utf8 and minipal_convert_utf16_to_utf8 from DAC #97055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsFixes #96747
|
jkoritzinsky
approved these changes
Jan 16, 2024
Member
Author
|
Failures look unrelated to this PR and are similar to #96904 |
Member
|
If we are going to use more minipal_utf8 functions, the utf8_to_utf16 counterparts will also need to be forwarded. |
Closed
tommcdon
added a commit
to tommcdon/runtime
that referenced
this pull request
Jan 21, 2024
…utf16_to_utf8 from DAC (dotnet#97055)" This reverts commit 1263107.
Merged
tommcdon
added a commit
that referenced
this pull request
Jan 21, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* Revert "Forward minipal_get_length_utf16_to_utf8 and minipal_convert_utf16_to_utf8 from DAC (dotnet#97055)" This reverts commit 1263107. * Revert "Cleanup some string operating functions (dotnet#96099)" This reverts commit bc81c55.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96747