Convert Array.CopySlow to managed #97202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
huoyaoyuan
commented
Jan 19, 2024
Member
|
It would be nice to make this as similar as possible to native AOT implementation (or even shared with native AOT). |
This was referenced Jan 19, 2024
This was referenced Jan 21, 2024
This was referenced Jan 22, 2024
huoyaoyuan
force-pushed
the
array-copyslow
branch
from
7876bfa to
17c9b23
Compare
huoyaoyuan
commented
Jan 24, 2024
huoyaoyuan
force-pushed
the
array-copyslow
branch
from
a5f929b to
491dd2e
Compare
jkotas
reviewed
Jan 24, 2024
jkotas
reviewed
Jan 24, 2024
This was referenced Jan 24, 2024
Member
|
@AaronRobinsonMSFT Could you please take a look as well? |
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
I will finish later tonight.
Co-authored-by: Aaron Robinson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes a case of HELPER_METHOD_FRAME.
The performance should not be a problem. The main concern is size.
coreclr.dll: 4864KB->4861KB, corelib R2R: 13660KB->13672KB