Update TestsManifestGeneration.Etw.cs #97258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable tests on x86
AaronRobinsonMSFT
added
area-System.Diagnostics.Tracing
disabled-test
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsDisable tests on x86 See #97255
|
ghost
assigned
tommcdon
approved these changes
Jan 21, 2024
Member
tommcdon
left a comment
tommcdon
left a comment
There was a problem hiding this comment.
Thanks for all of the investigation on this issue Aaron! I agree disabling the test is the right thing to do.
...braries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestGeneration.Etw.cs
Outdated
Show resolved
Hide resolved
...braries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestGeneration.Etw.cs
Outdated
Show resolved
Hide resolved
...braries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestGeneration.Etw.cs
Outdated
Show resolved
Hide resolved
...braries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestGeneration.Etw.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 21, 2024
Merged
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* Update TestsManifestGeneration.Etw.cs Disable tests on x86
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable tests on x86
See #97255