Skip to content

Conversation

@mangod9
Copy link
Member

@mangod9 mangod9 commented Jan 23, 2024

clrgcexp is standalone GC with Regions enabled and will also be used for experimental features.

clrgcexp is standalone GC with Regions enabled and will also be used for experimental features.
@ghost
Copy link

ghost commented Jan 23, 2024

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

clrgcexp is standalone GC with Regions enabled and will also be used for experimental features.

Author: mangod9
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

@ghost ghost assigned mangod9 Jan 23, 2024
@mrsharm mrsharm changed the title Add clrgcexp to NetCoreAppe Add clrgcexp to NetCoreApp Jan 23, 2024
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/env)

install_clr(TARGETS clrgc DESTINATIONS . sharedFramework COMPONENT runtime)
install_clr(TARGETS clrgcexp DESTINATIONS . sharedFramework COMPONENT runtime)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the two install_clr lines above (113 and 120) subsumed by these two? Regardless, should this new line be 64-bit-only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah needs to be 64-bit only. Have updated it now.

Copy link
Member

@mrsharm mrsharm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mangod9 mangod9 merged commit a4f41cc into dotnet:main Feb 8, 2024
@mangod9 mangod9 deleted the add_clrgcexp branch February 8, 2024 20:04
rolfbjarne added a commit to dotnet/macios that referenced this pull request Feb 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants