[browser][MT] send cancel to abandoned threads with event loop during mono_exit #97441

pavelsavara · 2024-01-24T08:30:09Z

MT improvements

cancelThreads will exit all JSWebWorker which are still running
- they are idle in the browser event loop preventing to be joined during mono_exit
- Solves [browser][MT] various WebWorkerTest CI failures #96628 (comment)
only register runtime into globalThis when it's ready started
- register it also with correct ID on the webworker
- this prevents workers to use instannce from dry run
don't load memory snapshot in worker
omit managed stack trace after runtime exited
improve logging prefix in MT, to contain thread type and time
move call mono_threads_wasm_on_thread_attached to better place and add parameters
simplified message passing between worker and main

testing

skip TimerTests on MT, where it doesn't make sense
fix WebWorkerTest
re-enable MT smoke tests in runtime pipeline
new -untilFailed xunit parameter for WasmTestRunner

…idle in the browser event loop) preventing to be joined during mono_exit - new `-untilFailed` xunit parameter for WasmTestRunner - cleanup CancellationToken in WebWorkerTest

ghost · 2024-01-24T08:30:18Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

cancelThreads will exit all JSWebWorker which are still running (idle in the browser event loop) preventing to be joined during mono_exit
new -untilFailed xunit parameter for WasmTestRunner
cleanup CancellationToken in WebWorkerTest

Solves #96628 (comment)

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`, `os-browser`
Milestone:	9.0.0

pavelsavara · 2024-01-24T08:30:38Z

/azp run runtime-wasm

azure-pipelines · 2024-01-24T08:30:48Z

Azure Pipelines successfully started running 1 pipeline(s).

- register it also with correct ID on the webworker - don't load memory snapshot in worker - omit managed stack trace after runtime exited - fix WebWorkerTest

pavelsavara · 2024-01-24T13:53:51Z

/azp run runtime-wasm

azure-pipelines · 2024-01-24T13:54:03Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-01-25T01:26:40Z

/azp run runtime-wasm

azure-pipelines · 2024-01-25T01:26:57Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-01-25T01:40:19Z

/azp run runtime-wasm

azure-pipelines · 2024-01-25T01:40:34Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-01-25T08:39:26Z

/azp run runtime-wasm

pavelsavara · 2024-01-26T19:52:59Z

/azp run runtime-wasm

azure-pipelines · 2024-01-26T19:53:10Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-01-27T14:11:34Z

/azp run runtime-wasm

azure-pipelines · 2024-01-27T14:11:51Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-01-27T15:52:20Z

~~I filled #97597~~ fixed

pavelsavara · 2024-01-28T17:46:56Z

/azp run runtime-wasm

azure-pipelines · 2024-01-28T17:47:05Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf

Looks good to me 👍

...ervices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTest.Http.cs

src/mono/browser/runtime/interp-pgo.ts

src/mono/browser/runtime/startup.ts

Co-authored-by: Marek Fišera <[email protected]>

pavelsavara · 2024-01-29T11:53:26Z

/azp run runtime-wasm

azure-pipelines · 2024-01-29T11:53:37Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-01-29T14:33:00Z

There are unrelated AOT failures

- cancelThreads will exit all JSWebWorker which are still running (…

7b829f9

…idle in the browser event loop) preventing to be joined during mono_exit - new `-untilFailed` xunit parameter for WasmTestRunner - cleanup CancellationToken in WebWorkerTest

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 24, 2024

pavelsavara added this to the 9.0.0 milestone Jan 24, 2024

pavelsavara requested a review from maraf January 24, 2024 08:30

pavelsavara self-assigned this Jan 24, 2024

pavelsavara added 4 commits January 24, 2024 11:37

don't load snapshot on threads

875eae2

- only register runtime into globalThis when it's ready started

52483a4

- register it also with correct ID on the webworker - don't load memory snapshot in worker - omit managed stack trace after runtime exited - fix WebWorkerTest

Merge branch 'main' into browser_abandoned_jswebworker_timeout

3d27902

more MT smoke tests

0a3a1a8

This was referenced Jan 24, 2024

[browser] RuntimeError: memory access out of bounds #96546

Closed

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049

Closed

improve thread prefix logging

a55dd62

more

f2354af

build-analysis bot mentioned this pull request Jan 25, 2024

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

pavelsavara added 2 commits January 25, 2024 09:38

fix

d090b37

Merge branch 'main' into browser_abandoned_jswebworker_timeout

21e6f20

pavelsavara marked this pull request as ready for review January 25, 2024 08:39

pavelsavara requested a review from lewing as a code owner January 25, 2024 08:39

pavelsavara added 2 commits January 26, 2024 19:29

more

82a549c

more

fed4ff3

pavelsavara requested a review from maraf January 26, 2024 19:52

build-analysis bot mentioned this pull request Jan 26, 2024

[browser][MT] Unhandled JS error #97546

Closed

build-analysis bot mentioned this pull request Jan 27, 2024

[browser] InterpPgoTests.FirstRunGeneratesTableAndSecondRunLoadsIt #97597

Closed

pavelsavara added 2 commits January 28, 2024 18:41

thread events

63df065

more cache logging

8069389

pavelsavara added 3 commits January 28, 2024 21:24

fix

fefe471

Merge branch 'main' into browser_abandoned_jswebworker_timeout

2d434a7

fix snapshot hash

a99547f

pavelsavara requested a review from ilonatommy as a code owner January 29, 2024 09:37

fix

902f173

maraf approved these changes Jan 29, 2024

View reviewed changes

...ervices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTest.Http.cs Outdated Show resolved Hide resolved

src/mono/browser/runtime/interp-pgo.ts Outdated Show resolved Hide resolved

src/mono/browser/runtime/startup.ts Outdated Show resolved Hide resolved

pavelsavara and others added 2 commits January 29, 2024 12:01

Update src/mono/browser/runtime/interp-pgo.ts

988cee6

Co-authored-by: Marek Fišera <[email protected]>

feedback

d025490

build-analysis bot mentioned this pull request Jan 29, 2024

[wasm] perf pipeline clang crashes on PERFTIGER200 #88148

Closed

pavelsavara merged commit fb953cc into dotnet:main Jan 29, 2024

pavelsavara deleted the browser_abandoned_jswebworker_timeout branch January 29, 2024 14:33

build-analysis bot mentioned this pull request Jan 29, 2024

Hitting OOM in LLVM for the wasi-wasm aot smoke tests #96630

Closed

github-actions bot locked and limited conversation to collaborators Feb 29, 2024

[browser][MT] send cancel to abandoned threads with event loop during mono_exit #97441

[browser][MT] send cancel to abandoned threads with event loop during mono_exit #97441

Uh oh!

Conversation

pavelsavara commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MT improvements

testing

Uh oh!

ghost commented Jan 24, 2024

Uh oh!

pavelsavara commented Jan 24, 2024

Uh oh!

azure-pipelines bot commented Jan 24, 2024

Uh oh!

pavelsavara commented Jan 24, 2024

Uh oh!

azure-pipelines bot commented Jan 24, 2024

Uh oh!

pavelsavara commented Jan 25, 2024

Uh oh!

azure-pipelines bot commented Jan 25, 2024

Uh oh!

pavelsavara commented Jan 25, 2024

Uh oh!

azure-pipelines bot commented Jan 25, 2024

Uh oh!

pavelsavara commented Jan 25, 2024

Uh oh!

pavelsavara commented Jan 26, 2024

Uh oh!

azure-pipelines bot commented Jan 26, 2024

Uh oh!

pavelsavara commented Jan 27, 2024

Uh oh!

azure-pipelines bot commented Jan 27, 2024

Uh oh!

pavelsavara commented Jan 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavelsavara commented Jan 28, 2024

Uh oh!

azure-pipelines bot commented Jan 28, 2024

Uh oh!

maraf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Jan 29, 2024

Uh oh!

azure-pipelines bot commented Jan 29, 2024

Uh oh!

pavelsavara commented Jan 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pavelsavara commented Jan 24, 2024 •

edited

Loading

pavelsavara commented Jan 27, 2024 •

edited

Loading