add regex test suggested by recent fix #97532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue Detailsrelates to #97463 which was for negative lookahead. this is for negative lookbehind.
|
stephentoub
approved these changes
Jan 26, 2024
|
@lewing I assume I can merge on red "smoke tests" but am I supposed to open an issue with matching pattern? How do I know? Clearly irrelevant to this PR but I believe there's ceremony around merge on red in this repo.. |
This was referenced Jan 26, 2024
|
I merged as I assume the two linked issues cover everything -- but I'm not sure how to tell? maybe there's a doc about this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #97463 which was for negative lookahead. this is for negative lookbehind.