[release/8.0-staging] [mono][jit] Fix passing of byref arguments in m… #97850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 2, 2024
Member
|
@vargaz will you backport the test to 8.0, also? |
…ono_gsharedvt_constrained_call (). (dotnet#97721) Fixes dotnet#97625.
vargaz
force-pushed
the
backport-97721
branch
from
4deb7ac to
50b457a
Compare
lambdageek
approved these changes
Feb 2, 2024
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
jeffschwMSFT
approved these changes
Feb 8, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 8.0.x
rbhanda
added
Servicing-approved
Contributor
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #97721 to release/8.0-staging
Customer Impact
A customer reported an issue where they were calling
SumorAverageon a List type of ~20K items resulting in a crash with an unclear stacktrace. After triaging, we noticed the runtime was not properly dereferencing byref values. We went in and fixed the glitch.Regression
Testing
Regression test added on CI to make sure this usage passes.
Also manually tested .Sum in a foreach and it works as expected.
Risk
Low