Skip to content

Conversation

@nikolahua
Copy link
Contributor

@nikolahua nikolahua commented Feb 4, 2024

This PR fixes CoreCLR interpreter at HelloWorld level.

IL code of Program:

.assembly a {}
.method void Main()
{
.entrypoint
ldstr "Hello World!"
call void [System.Private.CoreLib]Internal.Console::WriteLine(string)
ret
}

Run with command corerun -c /home/nikola/work/runtime/artifacts/bin/coreclr/linux.x64.Debug /home/nikola/work/runtime/t/hello.exe and following environment variables:

DOTNET_JitFunctionTrace=1
DOTNET_ForceInterpreter=1
DOTNET_Interpret=*
DOTNET_ZapDisable=1
DOTNET_ReadyToRun=0
DOTNET_DumpInterpreterStubs=1
DOTNET_TraceInterpreterEntries=1
DOTNET_TraceInterpreterIL=
DOTNET_TraceInterpreterOstack=
DOTNET_InterpreterHWIntrinsicsIsSupportedFalse=1
DOTNET_InterpreterDoLoopMethods=1
DOTNET_InterpretExclude=
DOTNET_TieredCompilation=0

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-VM-coreclr labels Feb 4, 2024
@nikolahua
Copy link
Contributor Author

Need review again.
Add option -p System.Diagnostics.Tracing.EventSource.IsSupported=false to command line:

corerun -c /home/nikola/work/runtime/artifacts/bin/coreclr/linux.x64.Debug -p System.Diagnostics.Tracing.EventSource.IsSupported=false /home/nikola/work/runtime/t/hello.exe

@nikolahua
Copy link
Contributor Author

Thanks for your patience. I am learning and exploring the workflow of PR. The suggested changes seemed to be combined into a new commit when I clicked 'Add suggestion to batch'. So I fixup each suggested change manually to corresponding commit and force push the branch. Not sure if it is a recommended way to do so.

@nikolahua nikolahua requested a review from jkotas February 6, 2024 09:14
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 2b01564 into dotnet:main Feb 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants