Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Feb 7, 2024

Also, rename SourceBuild.props to DotNetBuild.props to reflect its purpose.

Also, rename SourceBuild.props to DotNetBuild.props to reflect its purpose.
@ghost ghost assigned mmitche Feb 7, 2024
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 7, 2024
@mmitche mmitche requested review from a team and ViktorHofer February 7, 2024 15:34
@mmitche
Copy link
Member Author

mmitche commented Feb 7, 2024

Testing this in a full VMR build right now.

Category="Crossgen2Archive" />
</ItemGroup>

<ItemGroup Condition="'$(DotNetBuildOrchestrator)' == 'true'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm still confused. Why do we need this condition?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use DotNetBuild?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to accidentally include these in the intermediate nupkgs that are necessary for source-build repo legs. I don't think that they're actually produced for those legs, but this is to make sure. If we do, include a .deb for instance, we might hit the AzDO package size limit.

They're only necessary when installer (and probably consumes) upstream installers for building its own installers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason you can't use DotNetBuild is that it's active in a repo-only build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants